-
-
Notifications
You must be signed in to change notification settings - Fork 35
✨ add Python 3.14 support #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request adds support for Python 3.14 across the project's configuration files and CI/CD pipelines. The changes include updating the test workflow matrix, Dockerfile base image, tox configuration, project classifiers, and documentation to include Python 3.14 as a supported version. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes These are homogeneous configuration changes following established patterns across multiple files with no complex logic or functional modifications. Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #114 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 8 8
Lines 908 908
=======================================
Hits 900 900
Misses 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
117-117: Update Black target-version to include Python 3.14.The Black configuration should be synchronised with the newly-added Python 3.14 support to ensure formatting rules account for any version-specific syntax changes.
Apply this diff to include py314:
-target-version = ["py39", "py310", "py311", "py312", "py313"] +target-version = ["py39", "py310", "py311", "py312", "py313", "py314"]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.github/workflows/test.yml(11 hunks)CONTRIBUTING.md(1 hunks)Dockerfile(1 hunks)pyproject.toml(1 hunks)tox.ini(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Test (python3.9, mariadb:5.5, 1, true, 3.9)
- GitHub Check: Test (python3.10, mariadb:5.5, 1, true, 3.10)
- GitHub Check: Test (python3.11, mariadb:5.5, 1, true, 3.11)
- GitHub Check: Test (python3.12, mariadb:5.5, 1, true, 3.12)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (5)
CONTRIBUTING.md (1)
16-16: Documentation update is accurate.The version list correctly reflects Python 3.14 support being added across the project.
tox.ini (1)
9-9: Python 3.14 additions to tox configuration are correct.Both the envlist (line 9) and gh-actions mapping (line 22) follow the established pattern and are correctly positioned.
Also applies to: 22-22
pyproject.toml (1)
38-38: Classifier addition is correctly positioned.The new Python 3.14 classifier is properly placed in the version sequence.
Dockerfile (1)
1-1: Dockerfile base image update is appropriate.The version bump from Python 3.13 to 3.14 is straightforward, with no changes required to subsequent build steps.
.github/workflows/test.yml (1)
74-78: Test matrix additions are comprehensive and correctly structured.All 11 Python 3.14 entries (one per database variant) are:
- Properly positioned after their 3.13 counterparts
- Structurally consistent with existing matrix entries
- Configured with appropriate legacy_db and experimental flags per database version
Also applies to: 110-114, 146-150, 182-186, 218-222, 254-258, 290-294, 326-330, 362-366, 398-402, 434-438
This pull request adds support for Python 3.14 across the project’s tooling, test matrix, and documentation. The changes ensure that Python 3.14 is now included in CI tests, Docker builds, documentation, and package metadata, helping us stay current with the latest Python release and maintain compatibility.
Python 3.14 support additions:
.github/workflows/test.ymlfor all supported MariaDB and MySQL versions, both legacy and current, including experimental and non-experimental configurations. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Dockerfilebase image to usepython:3.14-alpineinstead ofpython:3.13-alpine.CONTRIBUTING.md).pyproject.toml.tox.inito add Python 3.14 to the environment list and interpreter mapping. [1] [2]