Skip to content

Update to use latest vcr-py cleaner#30

Merged
edthedev merged 20 commits intomainfrom
issue/29
Dec 16, 2025
Merged

Update to use latest vcr-py cleaner#30
edthedev merged 20 commits intomainfrom
issue/29

Conversation

@ddriddle
Copy link
Contributor

Closes #29

@ddriddle ddriddle self-assigned this Nov 13, 2025
mpitcel
mpitcel previously approved these changes Nov 13, 2025
zdc217
zdc217 previously approved these changes Nov 13, 2025
Copy link
Contributor

@edthedev edthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's verify that we can re-record the cassettes, before we merge.

@zdc217 zdc217 dismissed stale reviews from mpitcel and themself via e072900 November 13, 2025 21:59
@edthedev edthedev dismissed their stale review November 13, 2025 22:04

We recreated the cassettes during ensemble today. Nov 13

@zdc217
Copy link
Contributor

zdc217 commented Nov 13, 2025

Tests are failing due to version conflicts in the requirements file. Short term, we should try completely removing requirements-test.txt and the Makefile targets to see if we can let it build with any python version on GitHub.

@edthedev
Copy link
Contributor

Updated to use clean_domains from vcrpy-cleaner.
Getting an import error here, but the cleaner worked when re-recording...

@edthedev
Copy link
Contributor

I believe the static failures are because this project is testing under Python 3.10, rather than 3.13. make static passes under Python 3.13.

@edthedev
Copy link
Contributor

Now we are getting a complaint about test_failed_connectivity not replaying all bits. Probably we just need to cut the cassette shorter. We could also re-record the cassette, but be wary of locking ourselves out.

@edthedev edthedev merged commit c8ffe0b into main Dec 16, 2025
2 checks passed
@edthedev edthedev deleted the issue/29 branch December 16, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to use latest vcr-py cleaner

4 participants