Skip to content

fix(garmin): support regional MapShare endpoints and warn on full URL input#80

Merged
techtimo merged 1 commit into
mainfrom
fix/garmin-inreach-regional-url
May 6, 2026
Merged

fix(garmin): support regional MapShare endpoints and warn on full URL input#80
techtimo merged 1 commit into
mainfrom
fix/garmin-inreach-regional-url

Conversation

@techtimo
Copy link
Copy Markdown
Owner

@techtimo techtimo commented May 6, 2026

Summary

  • garmin_feed_share_base() now handles both bare usernames (JohnDoe) and full MapShare page URLs (https://eur-share.inreach.garmin.com/JohnDoe), building the correct Feed/Share API endpoint in either case — fixes data fetching for European/regional Garmin accounts
  • FeedModal shows a warning notice with the extracted username suggestion when the mapshare_address field contains a full URL, guiding users to correct their input
  • Provider field description updated to clarify only the username is expected

Test plan

  • Add a Garmin inReach feed with a bare username — verify it fetches from share.garmin.com/Feed/Share/{username}
  • Add a feed with a full URL (e.g. https://eur-share.inreach.garmin.com/User) — verify the warning notice appears with the extracted username, and fetching hits the correct regional endpoint
  • Edit an existing feed with a bare username — verify no warning is shown

… input

- garmin_feed_share_base() resolves both bare usernames and full MapShare
  page URLs (e.g. eur-share.inreach.garmin.com/User) to the correct
  Feed/Share API endpoint, enabling European/regional accounts to work
- FeedModal shows a warning notice with the extracted username when the
  mapshare_address field contains a full URL, guiding users to enter
  only the username
- Provider description updated to clarify username-only input is expected
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/spotmap-admin/components/FeedModal.jsx 50.00% 10 Missing ⚠️

📢 Thoughts on this report? Let us know!

@techtimo techtimo merged commit 9d812db into main May 6, 2026
5 checks passed
@techtimo techtimo deleted the fix/garmin-inreach-regional-url branch May 6, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant