fix(garmin): support regional MapShare endpoints and warn on full URL input#80
Merged
Merged
Conversation
… input - garmin_feed_share_base() resolves both bare usernames and full MapShare page URLs (e.g. eur-share.inreach.garmin.com/User) to the correct Feed/Share API endpoint, enabling European/regional accounts to work - FeedModal shows a warning notice with the extracted username when the mapshare_address field contains a full URL, guiding users to enter only the username - Provider description updated to clarify username-only input is expected
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
garmin_feed_share_base()now handles both bare usernames (JohnDoe) and full MapShare page URLs (https://eur-share.inreach.garmin.com/JohnDoe), building the correct Feed/Share API endpoint in either case — fixes data fetching for European/regional Garmin accountsFeedModalshows a warning notice with the extracted username suggestion when themapshare_addressfield contains a full URL, guiding users to correct their inputTest plan
share.garmin.com/Feed/Share/{username}https://eur-share.inreach.garmin.com/User) — verify the warning notice appears with the extracted username, and fetching hits the correct regional endpoint