feat(map): zoom-driven TRACK marker LOD via screen-space simplification#82
Merged
Conversation
Introduces LodManager, which hides/shows TRACK circle-dot markers in
lockstep with Leaflet's own polyline smoothFactor rendering. On each
zoomend, each feed's TRACK runs are projected to screen coordinates and
passed through L.LineUtil.simplify (the same algorithm and tolerance as
the polyline), so a marker is visible iff the polyline would show a bend
at that point.
- LOD activates only when total TRACK points across all feeds >= 10 000
- The last TRACK point and all TRACK points within 24 h of it are always
visible regardless of zoom level
- start() is triggered by map.once('moveend') registered before fitBounds
so the initial simplification fires at the correct zoom after the
animation settles
- refresh() short-circuits as soon as the 10 k threshold is confirmed,
avoiding a full scan on every zoom event
- Removes dead rebuildLinesForFeed() from LineManager (leftover from an
earlier geographic-RDP approach that was superseded)
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces LodManager, which hides/shows TRACK circle-dot markers in lockstep with Leaflet's own polyline smoothFactor rendering. On each zoomend, each feed's TRACK runs are projected to screen coordinates and passed through L.LineUtil.simplify (the same algorithm and tolerance as the polyline), so a marker is visible iff the polyline would show a bend at that point.