refactor: replace Symfony YAML with plain PHP for maps config#87
Merged
Conversation
Convert config/maps.yaml to config/maps.php (plain PHP array) and load it with require instead of Symfony YAML::parseFile. This removes the symfony/yaml Composer dependency and the Strauss vendor-prefix step entirely, fixing a fatal autoloader crash on the production server and simplifying the build (plugin-zip no longer needs composer install).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config/maps.yamltoconfig/maps.php(plain PHP array loaded withrequire)symfony/yamlfromcomposer.jsonand the Strauss vendor-prefix configuration entirelyvendor-prefixeddirectory from the zip and thecomposer installstep fromplugin-zipClass "Spotmap\Symfony\Component\Yaml\Yaml" not foundcrash on the production server caused by a partial Strauss run failing on achmodcall inside DockerTest plan
npm run plugin-zipcompletes without running composerconfig/maps.phpand novendor-prefixed/directory