Skip to content

Fix binary type bug in secrets-manager-secret module #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
posquit0 merged 1 commit into from
Apr 1, 2022
Merged

Fix binary type bug in secrets-manager-secret module #4

posquit0 merged 1 commit into from
Apr 1, 2022

Conversation

@posquit0
Copy link
Member

@posquit0 posquit0 commented Apr 1, 2022

Background

  • Remove the usage of base64encode function for BINARY type secrets-manager-secret module.
  • Fix local.latest.binary type error when type is KEY_VALUE.

@posquit0 posquit0 requested a review from a team April 1, 2022 19:28
@posquit0 posquit0 self-assigned this Apr 1, 2022
@github-actions github-actions bot added 💾 secrets-manager-secret This issue or pull request is related to secrets-manager-secret module. size/XS Extra Small size issue or PR. labels Apr 1, 2022
@posquit0 posquit0 merged commit 19dad97 into main Apr 1, 2022
@posquit0 posquit0 deleted the fix-bug-in-binary branch April 1, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@posquit0 posquit0

Labels

💾 secrets-manager-secret This issue or pull request is related to secrets-manager-secret module. size/XS Extra Small size issue or PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@posquit0