feat: improve how to use resource_group in modules

[posquit0]

Summary

Update resource group configuration to use object-based pattern.

Changes

• Update module version from ~> 0.10.0 to ~> 0.12.0
• Replace individual resource_group_* variables with single object variable
• Update all references to use var.resource_group.* structure
• Add resource_group output to each module

Modules Updated

• access-analyzer
• cloudtrail-event-data-store
• cloudtrail-trail
• config-managed-rule
• config-recorder
• macie-account

Test Plan

• Review variable changes
• Verify resource-group module references are correct
• Check outputs are properly formatted

[gemini-code-assist]

Summary of Changes

Hello @posquit0, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the resource group configuration within several AWS modules to adopt an object-based pattern for variables. The primary goal is to improve the usability and consistency of resource group settings by centralizing related parameters into a single, structured input. This change affects how resource group properties are defined and referenced, making the module interfaces cleaner and more intuitive for users.

Highlights

• Configuration Simplification: Migrated from multiple individual resource_group_* variables (e.g., resource_group_enabled, resource_group_name, resource_group_description) to a single, consolidated resource_group object variable. This streamlines how resource group settings are passed to modules.
• Module Version Update: The internal resource-group module dependency has been updated from version ~> 0.10.0 to ~> 0.12.0 across all affected modules.
• New Resource Group Output: Each updated module now exposes a resource_group output, providing details like the ARN and name of the created resource group, if enabled.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the resource group configuration across multiple modules to use a more modern object-based variable pattern, which is a great improvement for consistency and maintainability. The changes are well-implemented and consistently applied. I've added a few suggestions to simplify the new resource_group output blocks, making the code more concise and readable.

[gemini-code-assist]

The merge function with a ternary operator to conditionally add keys works, but it can be simplified. Using a single ternary expression for the entire value makes the intent clearer and the code more concise.

  value = (var.resource_group.enabled && var.module_tags_enabled) ? {
    enabled = true
    arn     = module.resource_group[0].arn
    name    = module.resource_group[0].name
  } : {
    enabled = false
  }

[gemini-code-assist]

The merge function with a ternary operator to conditionally add keys works, but it can be simplified. Using a single ternary expression for the entire value makes the intent clearer and the code more concise.

  value = (var.resource_group.enabled && var.module_tags_enabled) ? {
    enabled = true
    arn     = module.resource_group[0].arn
    name    = module.resource_group[0].name
  } : {
    enabled = false
  }

[gemini-code-assist]

The merge function with a ternary operator to conditionally add keys works, but it can be simplified. Using a single ternary expression for the entire value makes the intent clearer and the code more concise.

  value = (var.resource_group.enabled && var.module_tags_enabled) ? {
    enabled = true
    arn     = module.resource_group[0].arn
    name    = module.resource_group[0].name
  } : {
    enabled = false
  }

[gemini-code-assist]

The merge function with a ternary operator to conditionally add keys works, but it can be simplified. Using a single ternary expression for the entire value makes the intent clearer and the code more concise.

  value = (var.resource_group.enabled && var.module_tags_enabled) ? {
    enabled = true
    arn     = module.resource_group[0].arn
    name    = module.resource_group[0].name
  } : {
    enabled = false
  }

[gemini-code-assist]

The merge function with a ternary operator to conditionally add keys works, but it can be simplified. Using a single ternary expression for the entire value makes the intent clearer and the code more concise.

  value = (var.resource_group.enabled && var.module_tags_enabled) ? {
    enabled = true
    arn     = module.resource_group[0].arn
    name    = module.resource_group[0].name
  } : {
    enabled = false
  }

[gemini-code-assist]

The merge function with a ternary operator to conditionally add keys works, but it can be simplified. Using a single ternary expression for the entire value makes the intent clearer and the code more concise.

  value = (var.resource_group.enabled && var.module_tags_enabled) ? {
    enabled = true
    arn     = module.resource_group[0].arn
    name    = module.resource_group[0].name
  } : {
    enabled = false
  }