CI Support for msnodesqlv8 on node 10#1368
Merged
dhensby merged 2 commits intotediousjs:masterfrom Feb 24, 2022
Merged
Conversation
dhensby
force-pushed
the
pulls/msnode-fix
branch
from
6fbd0a3 to
29610ac
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does:
See TimelordUK/node-sqlserver-v8#232
msnodesqlv8 accidentally broke Node 10 support in 2.4.5 release. This change conditionally installs the 2.4.4 version if testing on Node 10
Related issues:
TimelordUK/node-sqlserver-v8#232
Pre/Post merge checklist: