fix: add login timeout to sqlcmd in waitForDatabase#202
Merged
dhensby merged 1 commit intotediousjs:masterfrom Apr 14, 2026
Merged
fix: add login timeout to sqlcmd in waitForDatabase#202dhensby merged 1 commit intotediousjs:masterfrom
dhensby merged 1 commit intotediousjs:masterfrom
Conversation
Without a timeout, each sqlcmd invocation could block indefinitely if the database is hanging, preventing the retry loop from progressing. Add -l 5 (5 second login timeout) so connections fail fast and the exponential backoff can retry promptly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🎉 This PR is included in version 3.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
waitForDatabase()function callssqlcmdwithout a login timeout (-lflag). If the database is hanging or unresponsive, each invocation could block indefinitely, preventing the exponential backoff retry loop from progressing.Fix
Add
-l 5(5 second login timeout) to thesqlcmdarguments. This ensures connections fail fast so the retry loop can back off and try again promptly.