Conversation
LecrisUT
approved these changes
Nov 14, 2025
Member
LecrisUT
left a comment
LecrisUT
left a comment
There was a problem hiding this comment.
LGTM. Please also patch tmt.steps.execute.Execute.create_results
Contributor
Author
Why so? |
happz
force-pushed
the
phase-result-guest
branch
2 times, most recently
from
fc77988 to
8b6b98f
Compare
Member
Ah, I thought it was using a guest instance, but yeah those are just strings, nvm it. |
happz
added
the
status | blocking other work
happz
force-pushed
the
phase-result-guest
branch
3 times, most recently
from
dfae0ef to
f47f202
Compare
skycastlelily
approved these changes
Dec 8, 2025
Contributor
skycastlelily
left a comment
skycastlelily
left a comment
There was a problem hiding this comment.
LGTM^^, expect the typo-ish
happz
force-pushed
the
phase-result-guest
branch
from
f47f202 to
d349fe9
Compare
vaibhavdaren
approved these changes
Dec 8, 2025
Member
|
/packit retest-failed |
psss
force-pushed
the
phase-result-guest
branch
from
d349fe9 to
b747261
Compare
Member
|
Red job is an irrelevant guest failure, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist