Conversation
happz
added
code | no functional change
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors how PhaseQueue is handled in various steps (cleanup, execute, finish, prepare) by introducing a new base class StepWithQueue. This new class initializes and holds the queue, making it a step-level attribute _queue instead of a local variable within go() methods. This change is intended to expose the queue for external modifications. The implementation is clean and consistent across all affected steps. I have one suggestion to improve the logger naming for the queue to avoid redundancy.
LecrisUT
reviewed
Mar 23, 2026
happz
force-pushed
the
step-with-queue
branch
2 times, most recently
from
7586db8 to
3ac5911
Compare
LecrisUT
approved these changes
Mar 26, 2026
Contributor
tcornell-bus
left a comment
tcornell-bus
left a comment
There was a problem hiding this comment.
Cursor pointed out a few things and I verified
happz
force-pushed
the
step-with-queue
branch
3 times, most recently
from
445e4a3 to
ab7c95e
Compare
2 tasks
tcornell-bus
approved these changes
Mar 30, 2026
Queues are "burried" inside `go()` methods, but if we want to support addition of new tasks from outside of the step, the queue needs to become step-level instance attribute so it can be modified from outside of `go()`. Related to #4726
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queues are "buried" inside
go()methods, but if we want to support addition of new tasks from outside of the step, the queue needs to become step-level instance attribute so it can be modified from outside ofgo().Related to #4726
Pull Request Checklist