Cleanup step should apply to all guests, even not ready ones#4866
Conversation
happz
added
bug
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors guest handling by introducing a _steppify_guest helper and splitting guest retrieval into _steppified_guests (all guests) and _steppified_ready_guests (ready guests). Feedback highlights that redefining _steppified_guests to include all guests is a breaking change that could cause regressions in steps like execute. Furthermore, the ready_only parameter in add_phase is currently ineffective for go() methods because it is not stored within the Phase object. Minor documentation and grammar improvements were also suggested.
|
Related to #4185 and co also? I think there are 1-2 more similar issues |
Maybe, I don't know. I'm fixing issue reported in #4834, found another two based bugs right there, if there are other issues fixed by this, please, mention them, as I don't recall them. #4185 namely seems to be dealing with different part of the guest/cleanup workflow, so I dare to say this PR is not related. |
psss
force-pushed
the
cleanup-for-all-guests
branch
from
c6f3677 to
a8429ab
Compare
4 participants
Related to #4834.
Pull Request Checklist