This repository was archived by the owner on Aug 20, 2025. It is now read-only.
Changed loading secrets testing from yaml file to loading from enviro…#7
Closed
marvin8 wants to merge 1 commit intotehtbl:masterfrom
marvin8:master
Closed
Changed loading secrets testing from yaml file to loading from enviro…#7marvin8 wants to merge 1 commit intotehtbl:masterfrom marvin8:master
marvin8 wants to merge 1 commit intotehtbl:masterfrom
marvin8:master
Conversation
…nment variables. -> Removes dependency to yaml Replaced use of requests to use the more modern httpx (https://www.python-httpx.org/) -> Replaces dependency of requests with httpx Replaced 'print "..."' statements with the python 3 version ('print("...")') in getMyBalances.py
Author
|
Oh... on the use of environment variables... if you are using any ot the JetBrains IDEs (I use PyCharm) you can checkout the 'EnvFile' plugin which can set environment variables from a Yaml file as well.. :) |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off, thank you for creating this wonderful Cointracking API for python.
I made the changes in this PR mainly for myself. I seem to be having trouble getting
PyYAMLinstall in my Python 3.9 environment and because of this was motivated to make these changes. Because of this I am unsure of the value of my changes to you and any other users of ctapi. Either way, I thought I'll share my changes just for the fun of it.Feel free to disregard this PR, comment on it or approve it... which ever suits you best.
Actual Changes:
print "..."statements with the python 3 versionprint("...")in getMyBalances.py