Fix Ktlint workflow to include .kts files#13
Conversation
Updated Ktlint workflow to include .kts files in subdirectories.
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
WalkthroughGitHub Actions workflow configuration updated to improve Kotlin file detection across the repository and enable manual workflow triggering via the Actions UI. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/ktlint.yml (1)
7-7: Consolidate redundant path filters.Line 9's
**/*.ktpattern is a superset that already matches all files covered by line 7'ssrc/**/*.kt. Consider removing line 7 to simplify the configuration while maintaining identical coverage.on: pull_request: paths: - .github/workflows/ktlint.yml - - 'src/**/*.kt' - '**/*.kts' - '**/*.kt'Also applies to: 9-9
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/ktlint.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: build
- GitHub Check: Build lyrics-maker
- GitHub Check: dependency-submission
- GitHub Check: Build app
🔇 Additional comments (2)
.github/workflows/ktlint.yml (2)
8-9: Glob patterns corrected for Kotlin file detection. ✓The fixes are correct:
- Line 8:
**/*.ktsis the proper glob pattern (replacing the invalid**.kts) to match .kts files at any depth.- Line 9:
**/*.ktcatches all .kt files regardless of directory structure.
10-10:workflow_dispatchaddition improves usability. ✓Manual workflow triggers are helpful for local testing and re-running checks without pushing new commits.
Updated Ktlint workflow to include .kts files in subdirectories.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.