Simplify looking up the RekorAnnotation, add Unit Test for HandleRetry failure#232
Conversation
Add a unit test for making sure that if the retry has been exceeded the TaskRun gets marked as failed.
|
Hi @vaikas. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlorenc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Simplify looking up the RekorAnnotation, no need for a for loop.
Add a unit test for making sure that if the retry has been exceeded
the TaskRun gets marked as failed.