Skip to content

Simplify looking up the RekorAnnotation, add Unit Test for HandleRetry failure#232

Merged
tekton-robot merged 1 commit into
tektoncd:mainfrom
vaikas:remove-for-loop
Sep 17, 2021
Merged

Simplify looking up the RekorAnnotation, add Unit Test for HandleRetry failure#232
tekton-robot merged 1 commit into
tektoncd:mainfrom
vaikas:remove-for-loop

Conversation

@vaikas

@vaikas vaikas commented Sep 17, 2021

Copy link
Copy Markdown
Contributor

Simplify looking up the RekorAnnotation, no need for a for loop.

Add a unit test for making sure that if the retry has been exceeded
the TaskRun gets marked as failed.

Add a unit test for making sure that if the retry has been exceeded
the TaskRun gets marked as failed.
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 17, 2021
@tekton-robot

Copy link
Copy Markdown

Hi @vaikas. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 17, 2021
@priyawadhwa

Copy link
Copy Markdown
Contributor

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 17, 2021
@dlorenc

dlorenc commented Sep 17, 2021

Copy link
Copy Markdown
Contributor

/lgtm

@dlorenc

dlorenc commented Sep 17, 2021

Copy link
Copy Markdown
Contributor

/approve

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2021
@tekton-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlorenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2021
@tekton-robot tekton-robot merged commit fe76b61 into tektoncd:main Sep 17, 2021
@vaikas vaikas deleted the remove-for-loop branch September 22, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants