Capture step information inrecipe.arguments for in-toto/slsa Provenance

[pxp928]

POC for #271 for adding further detail into the environment for each step within a taksrun. (https://slsa.dev/provenance/v0.1)

"recipe": { "type": "<URI>", "definedInMaterial": /* integer */, "entryPoint": "<STRING>", "arguments": { /* object */ }, "environment": { /* object */ }

This added information would provide more information for each step within the taskrun and capture proper entrypoints for each step. This update would allow for better verfication viain-toto verify in the future.

[tekton-robot]

Hi @pxp928. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[priyawadhwa]

If the step in the tekton-provenance format meets your needs, you could probably just make this function public and call it to get the steps for the TaskRun :)

chains/pkg/chains/formats/provenance/provenance.go

Line 223 in e53b16a

func recipe(tr *v1beta1.TaskRun) provenance.ProvenanceRecipe {

You may have to refactor a little to return Steps instead of ProvenanceRecipe!

[pxp928]

If the step in the tekton-provenance format meets your needs, you could probably just make this function public and call it to get the steps for the TaskRun :)

chains/pkg/chains/formats/provenance/provenance.go

Line 223 in e53b16a

func recipe(tr *v1beta1.TaskRun) provenance.ProvenanceRecipe {

You may have to refactor a little to return Steps instead of ProvenanceRecipe!

Thanks for the feedback Priya. I will work on this today.

[pxp928]

Updated to use Recipe from provenance.go. Updated unit tests based on the change in output to include step information.

[priyawadhwa]

Looks good! just one comment. I'll run tests as well!

[priyawadhwa]

/ok-to-test

[priyawadhwa]

Hey @pxp928 looks like our integration test for the in-toto attestations is failing. You'll need to update our test file with the expected output now that recipe.arguments is included here

[pxp928]

Hey @pxp928 looks like our integration test for the in-toto attestations is failing. You'll need to update our test file with the expected output now that recipe.arguments is included here

Thanks Priya! I will fix this issue and get it submitted.

[priyawadhwa]

amazing, lgtm!

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [priyawadhwa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[priyawadhwa]

/lgtm