Skip to content

Deprecate the tekton-provenance predicate format#292

Merged
tekton-robot merged 1 commit into
tektoncd:mainfrom
priyawadhwa:deprecate
Dec 2, 2021
Merged

Deprecate the tekton-provenance predicate format#292
tekton-robot merged 1 commit into
tektoncd:mainfrom
priyawadhwa:deprecate

Conversation

@priyawadhwa

@priyawadhwa priyawadhwa commented Nov 30, 2021

Copy link
Copy Markdown
Contributor

Added in a doc to describe how we plan to deprecate features. We can make an announcement for deprecation and then actually remove the feature two releases later.

For now, this will still work but we just print the error message.
It can be removed in a future release, and I removed all docs around it as well.
#293
ref #249

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 30, 2021
@tekton-robot

Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/provenance/provenance.go 68.1% 67.6% -0.5
pkg/chains/signing.go 78.2% 79.2% 1.0

@priyawadhwa priyawadhwa force-pushed the deprecate branch 2 times, most recently from 5259c64 to e1655f2 Compare November 30, 2021 18:36
@tekton-robot

Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/provenance/provenance.go 68.1% 67.6% -0.5
pkg/chains/signing.go 78.2% 79.2% 1.0

@tekton-robot

Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/provenance/provenance.go 68.1% 67.6% -0.5
pkg/chains/signing.go 78.2% 79.2% 1.0

@tekton-robot

Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/provenance/provenance.go 68.1% 67.6% -0.5
pkg/chains/signing.go 78.2% 79.2% 1.0

@lukehinds

Copy link
Copy Markdown

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2021
@priyawadhwa

Copy link
Copy Markdown
Contributor Author

Hey @lukehinds thanks for the lgtm! I think prow also needs an /approved for this to merge 😅

Comment thread docs/deprecations.md Outdated
Comment thread docs/deprecations.md Outdated
For now, this will still work but we just print the error message.
It can be removed in a future release, and I removed all docs around it as well.
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2021
@tekton-robot

Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/formats/provenance/provenance.go 68.1% 67.6% -0.5
pkg/chains/signing.go 78.2% 79.2% 1.0

@dlorenc

dlorenc commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

/approve

@tekton-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlorenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2021
@dlorenc

dlorenc commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2021
@tekton-robot tekton-robot merged commit 48a85c4 into tektoncd:main Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants