Skip to content

Make builder id for SLSA provenance valid URI#331

Merged
tekton-robot merged 1 commit into
tektoncd:mainfrom
mlieberman85:fix-uri
Jan 13, 2022
Merged

Make builder id for SLSA provenance valid URI#331
tekton-robot merged 1 commit into
tektoncd:mainfrom
mlieberman85:fix-uri

Conversation

@mlieberman85

Copy link
Copy Markdown
Contributor

The SLSA provenance v0.2 spec requires that the builder.id be a
valid URI. It was just "tekton-chains" this changes it to
"https://tekton.dev/chains/v2"

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 12, 2022
@tekton-robot

Copy link
Copy Markdown

Hi @mlieberman85. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 12, 2022
@mlieberman85

Copy link
Copy Markdown
Contributor Author

This should fix #308

@loosebazooka

Copy link
Copy Markdown
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2022
@loosebazooka

Copy link
Copy Markdown
Contributor

will wait for @priyawadhwa to approve.

@loosebazooka

Copy link
Copy Markdown
Contributor

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 12, 2022

@priyawadhwa priyawadhwa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mlieberman85 !

@tekton-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2022
@priyawadhwa

Copy link
Copy Markdown
Contributor

Looks like you'll need to update TestParse as well

@mlieberman85

Copy link
Copy Markdown
Contributor Author

Thanks, will update tomorrow and push out.

The SLSA provenance v0.2 spec requires that the builder.id be a
valid URI. It was just "tekton-chains" this changes it to
"https://tekton.dev/chains/v2"
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 13, 2022
@priyawadhwa

Copy link
Copy Markdown
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2022
@tekton-robot tekton-robot merged commit 42060b8 into tektoncd:main Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants