Skip to content

Remove un-used options from artifacts.oci.format and artifacts.oci.storage#334

Merged
tekton-robot merged 1 commit into
tektoncd:mainfrom
pxp928:remove-tekton-from-oci
Jan 20, 2022
Merged

Remove un-used options from artifacts.oci.format and artifacts.oci.storage#334
tekton-robot merged 1 commit into
tektoncd:mainfrom
pxp928:remove-tekton-from-oci

Conversation

@pxp928

@pxp928 pxp928 commented Jan 14, 2022

Copy link
Copy Markdown
Member

Address issue #332

Removing the tekton option for artifacts.oci.format as it causes the errors with signature validation via cosign.
Change to have oci as an the only option for artifacts.oci.storage

@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 14, 2022
@tekton-robot

Copy link
Copy Markdown

Hi @pxp928. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@priyawadhwa

Copy link
Copy Markdown
Contributor

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 14, 2022
@pxp928

pxp928 commented Jan 14, 2022

Copy link
Copy Markdown
Member Author

Reworking the integration tests

@pxp928 pxp928 force-pushed the remove-tekton-from-oci branch from baa2d95 to 2971974 Compare January 14, 2022 21:10
@pxp928 pxp928 force-pushed the remove-tekton-from-oci branch from 2971974 to b9c58d5 Compare January 19, 2022 13:37
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 19, 2022

@priyawadhwa priyawadhwa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this!

@tekton-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2022
@priyawadhwa

Copy link
Copy Markdown
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2022
@tekton-robot tekton-robot merged commit 3b2192f into tektoncd:main Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants