Skip to content

Change default Fulcio URL to match cosign's#360

Merged
tekton-robot merged 1 commit into
tektoncd:mainfrom
tcnghia:change-default-fulcio
Feb 4, 2022
Merged

Change default Fulcio URL to match cosign's#360
tekton-robot merged 1 commit into
tektoncd:mainfrom
tcnghia:change-default-fulcio

Conversation

@tcnghia

@tcnghia tcnghia commented Feb 3, 2022

Copy link
Copy Markdown
Contributor

Currently cosign is using https://v1.fulcio.sigstore.dev as the default. Changing chains to use the same.

Signed-off-by: Nghia Tran tcnghia@gmail.com

@linux-foundation-easycla

linux-foundation-easycla Bot commented Feb 3, 2022

Copy link
Copy Markdown

CLA Signed

The committers are authorized under a signed CLA.

@tcnghia tcnghia changed the title Change default Fulcio URL to match cosign's. Change default Fulcio URL to match cosign's Feb 3, 2022
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 3, 2022
@tekton-robot

Copy link
Copy Markdown

Hi @tcnghia. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Nghia Tran <tcnghia@gmail.com>
@tcnghia tcnghia force-pushed the change-default-fulcio branch from d5fd186 to 2c5ec32 Compare February 3, 2022 23:51

@priyawadhwa priyawadhwa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY for fixing this!!

So we do have a test for this but unfortunately we can't run it in CI because our CI cluster doesn't have workload identity enabled.

Would you mind running it locally to make sure this passes?

go test -tags=e2e -run TestFulcio ./test/... 

LMK if it doesn't work!

@tcnghia

tcnghia commented Feb 4, 2022

Copy link
Copy Markdown
Contributor Author

@priyawadhwa Thanks for the pointer! The test passed for me

go test -tags=e2e -run TestFulcio ./test/... 

ok  	github.com/tektoncd/chains/test	101.788s

@tekton-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2022
@priyawadhwa

Copy link
Copy Markdown
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2022
@priyawadhwa

Copy link
Copy Markdown
Contributor

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 4, 2022
@tekton-robot tekton-robot merged commit 4ebc18d into tektoncd:main Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants