Change default Fulcio URL to match cosign's#360
Conversation
|
|
|
Hi @tcnghia. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Nghia Tran <tcnghia@gmail.com>
d5fd186 to
2c5ec32
Compare
priyawadhwa
left a comment
There was a problem hiding this comment.
TY for fixing this!!
So we do have a test for this but unfortunately we can't run it in CI because our CI cluster doesn't have workload identity enabled.
Would you mind running it locally to make sure this passes?
go test -tags=e2e -run TestFulcio ./test/...
LMK if it doesn't work!
|
@priyawadhwa Thanks for the pointer! The test passed for me |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: priyawadhwa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/ok-to-test |
Currently cosign is using https://v1.fulcio.sigstore.dev as the default. Changing chains to use the same.
Signed-off-by: Nghia Tran tcnghia@gmail.com