Pass in authentication when getting remote image#361
Merged
Conversation
|
tekton-robot
added
the
size/XS
|
Contributor
Author
|
/check-cla |
1 similar comment
Contributor
Author
|
/check-cla |
priyawadhwa
force-pushed
the
eks-debug
branch
from
05e7272 to
878b90a
Compare
|
priyawadhwa
force-pushed
the
eks-debug
branch
from
878b90a to
5270b44
Compare
|
priyawadhwa
force-pushed
the
eks-debug
branch
from
5270b44 to
1bcdf02
Compare
|
We need to pass this in, otherwise authentication can fail at this step. Caught while I was trying to run Chains on EKS and push to ECR! Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
priyawadhwa
force-pushed
the
eks-debug
branch
from
1bcdf02 to
da851ce
Compare
priyawadhwa
changed the title
mattmoor
approved these changes
Feb 4, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to pass this in, otherwise authentication can fail at this step. Caught while I was trying to run Chains on EKS and push to ECR!