Skip to content

Revert default fulcio URL to fulcio.sigstore.dev#388

Merged
tekton-robot merged 1 commit into
tektoncd:mainfrom
priyawadhwa:fulcio-default
Mar 1, 2022
Merged

Revert default fulcio URL to fulcio.sigstore.dev#388
tekton-robot merged 1 commit into
tektoncd:mainfrom
priyawadhwa:fulcio-default

Conversation

@priyawadhwa

Copy link
Copy Markdown
Contributor

now, fulcio.sigstore.dev and v1.fulcio.sigstore.dev point to the same service, so we can switch back.

cc @tcnghia who originally found this bug

@tekton-robot tekton-robot requested review from dlorenc and font March 1, 2022 20:53
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 1, 2022
now, fulcio.sigstore.dev and v1.fulcio.sigstore.dev point to the same service, so we can switch back.

@wlynch wlynch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot

Copy link
Copy Markdown

@wlynch: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dlorenc

dlorenc commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2022
@dlorenc

dlorenc commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

/approve

@tekton-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlorenc, wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2022
@tekton-robot tekton-robot merged commit 8b29855 into tektoncd:main Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants