Skip to content

Fix nightly builds#422

Merged
tekton-robot merged 1 commit into
tektoncd:mainfrom
lcarva:fix-nightly-builds
Apr 21, 2022
Merged

Fix nightly builds#422
tekton-robot merged 1 commit into
tektoncd:mainfrom
lcarva:fix-nightly-builds

Conversation

@lcarva

@lcarva lcarva commented Apr 20, 2022

Copy link
Copy Markdown
Contributor

The plubming project has a reference to the 'release' directory of the
chains project. This is a kustomize remote resource reference. In order
to satisfy 'kustomize build', add a new kustomization.yaml file under
the 'release' directory.

Signed-off-by: Luiz Carvalho lucarval@redhat.com

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 20, 2022
@tekton-robot

tekton-robot commented Apr 20, 2022

Copy link
Copy Markdown

Hi @lcarva. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 20, 2022
@lcarva

lcarva commented Apr 20, 2022

Copy link
Copy Markdown
Contributor Author

This should fix https://dashboard.dogfooding.tekton.dev/#/namespaces/default/taskruns/deploy-resources-tekton-hkxrf?step=deploy-from-folder

At least running the kustomize build tekton command from the plumbing repo (with a reference to this PR) works now.

cc @vdemeester

@vdemeester vdemeester mentioned this pull request Apr 21, 2022
Closed
4 tasks
vdemeester
vdemeester approved these changes Apr 21, 2022
View reviewed changes

@vdemeester vdemeester left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 21, 2022
@vdemeester

vdemeester commented Apr 21, 2022

Copy link
Copy Markdown
Member

/assign @mattmoor

@priyawadhwa

priyawadhwa commented Apr 21, 2022

Copy link
Copy Markdown
Contributor

/test pull-tekton-chains-build-tests

@priyawadhwa

priyawadhwa commented Apr 21, 2022

Copy link
Copy Markdown
Contributor

/lgtm

@lcarva

lcarva commented Apr 21, 2022

Copy link
Copy Markdown
Contributor Author

@priyawadhwa, I can't imagine the failed test is related to this change.

@lcarva
Fix nightly builds
1f8a4d0 
The plubming project has a reference to the 'release' directory of the
chains project. This is a kustomize remote resource reference. In order
to satisfy 'kustomize build', add a new kustomization.yaml file under
the 'release' directory.

Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
@lcarva lcarva force-pushed the fix-nightly-builds branch from f7a6f8d to 1f8a4d0 Compare April 21, 2022 13:50
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 21, 2022
@lcarva

lcarva commented Apr 21, 2022

Copy link
Copy Markdown
Contributor Author

@priyawadhwa, I can't imagine the failed test is related to this change.

Hmm. Well the license check failure does related to these changes, fixed it. Unclear about the other error reported.

@lcarva

lcarva commented Apr 21, 2022

Copy link
Copy Markdown
Contributor Author

@priyawadhwa, all tests are passing now 🙂

@mattmoor

mattmoor commented Apr 21, 2022

Copy link
Copy Markdown
Member

Hmm, I don't have context here's so I'll defer to @priyawadhwa

@tekton-robot

tekton-robot commented Apr 21, 2022

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2022
@priyawadhwa

priyawadhwa commented Apr 21, 2022

Copy link
Copy Markdown
Contributor

The other test is flaky! We should be good to go :)

@priyawadhwa

priyawadhwa commented Apr 21, 2022

Copy link
Copy Markdown
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2022
@tekton-robot tekton-robot merged commit 6e61b1d into tektoncd:main Apr 21, 2022
@lcarva lcarva mentioned this pull request May 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdemeester vdemeester vdemeester approved these changes
@priyawadhwa priyawadhwa priyawadhwa approved these changes
@font font Awaiting requested review from font
@loosebazooka loosebazooka Awaiting requested review from loosebazooka

Assignees

@vdemeester vdemeester

@mattmoor mattmoor

@priyawadhwa priyawadhwa

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lcarva @tekton-robot @vdemeester @priyawadhwa @mattmoor