Skip to content

Clarify documentation for storage.oci.repository#510

Merged
tekton-robot merged 3 commits into
tektoncd:mainfrom
bendory:oci
Aug 10, 2022
Merged

Clarify documentation for storage.oci.repository#510
tekton-robot merged 3 commits into
tektoncd:mainfrom
bendory:oci

Conversation

@bendory

@bendory bendory commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 9, 2022
@bendory

bendory commented Aug 9, 2022

Copy link
Copy Markdown
Contributor Author

@chuangw6 PTAL

@bendory

bendory commented Aug 9, 2022

Copy link
Copy Markdown
Contributor Author

@Yongxuanzhang PTAL

@bendory

bendory commented Aug 9, 2022

Copy link
Copy Markdown
Contributor Author

/retest

@bendory

bendory commented Aug 9, 2022

Copy link
Copy Markdown
Contributor Author

/kind documentation

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 9, 2022

@Yongxuanzhang Yongxuanzhang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this clarification! And for your screenshot maybe we should hide some personal information like your project id etc?

Comment thread docs/config.md Outdated
@bendory

bendory commented Aug 9, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for adding this clarification! And for your screenshot maybe we should hide some personal information like your project id etc?

I thought about that; the project is already deleted, so it should be harmless.
LMK if you have good reason to think otherwise.

Comment thread docs/config.md Outdated

@Yongxuanzhang Yongxuanzhang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Co-authored-by: Yongxuan Zhang <44033547+Yongxuanzhang@users.noreply.github.com>
@wlynch

wlynch commented Aug 10, 2022

Copy link
Copy Markdown
Member

/lgtm
/approve

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2022
@tekton-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2022
@tekton-robot tekton-robot merged commit 24c5313 into tektoncd:main Aug 10, 2022
@bendory bendory deleted the oci branch August 10, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants