Skip to content

Pinning sigstore/scaffolding/actions/setup version#512

Merged
tekton-robot merged 1 commit into
tektoncd:mainfrom
bcaton85:e2e-fix
Aug 9, 2022
Merged

Pinning sigstore/scaffolding/actions/setup version#512
tekton-robot merged 1 commit into
tektoncd:mainfrom
bcaton85:e2e-fix

Conversation

@bcaton85

@bcaton85 bcaton85 commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2022
@tekton-robot

Copy link
Copy Markdown

Hi @bcaton85. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wlynch

wlynch commented Aug 9, 2022

Copy link
Copy Markdown
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2022
@wlynch

wlynch commented Aug 9, 2022

Copy link
Copy Markdown
Member

/lgtm
/approve

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 9, 2022
- name: Install mirror, kind, knative + sigstore
uses: sigstore/scaffolding/actions/setup@main
with:
version: v0.3.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please add this:
k8s-version 1.22

so like this:

with:
  version: "v0.3.0"
  k8s-version: "v1.22.x"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because 23 is being goofy:
sigstore/scaffolding#81

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, updated.

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2022
@vaikas

vaikas commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

/ok-to-test

Comment thread .github/workflows/kind-e2e.yaml Outdated
@tekton-robot tekton-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2022
@wlynch

wlynch commented Aug 9, 2022

Copy link
Copy Markdown
Member

/lgtm
/approve

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 9, 2022
@bcaton85

bcaton85 commented Aug 9, 2022

Copy link
Copy Markdown
Contributor Author

@vaikas seems v1.21.x is failing. We're currently using k8s-version: ${{ matrix.k8s-version }}. Is there an easy fix for that? Not sure if we want to remove it from the test

@vaikas

vaikas commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

@bcaton85 So, it seems like the tests were passing fine just a few days ago here:

https://github.com/tektoncd/chains/runs/7697397547?check_suite_focus=true

What's curious is that it was running very old version

SIGSTORE_SCAFFOLDING_RELEASE_VERSION: v0.1.19

So I wonder if you could just use an older version of the action, instead of using main, maybe grab this hash:
https://github.com/sigstore/scaffolding/releases/tag/v0.3.0

I guess your uses would look like this:

uses: sigstore/scaffolding/actions/setup@74d1900f01c1f717f121e0436c4e1996fa55e986

And take out the with. At least I think that should run the version that was working just fine before.

vaikas added a commit to vaikas/chains that referenced this pull request Aug 9, 2022
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
vaikas added a commit to vaikas/chains that referenced this pull request Aug 9, 2022
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@wlynch

wlynch commented Aug 9, 2022

Copy link
Copy Markdown
Member

@vaikas - not sure if that version was actually used - https://github.com/tektoncd/chains/runs/7697397547?check_suite_focus=true#step:7:114 looks like it ignored the env var and used 0.3.0. edit: I think we were saying the same thing. Worth a shot!

I'm tempted to just drop 1.21 - it's EOL anyway. 🤔

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2022
@bcaton85

bcaton85 commented Aug 9, 2022

Copy link
Copy Markdown
Contributor Author

Sounds good, updated to use the hash.

@wlynch

wlynch commented Aug 9, 2022

Copy link
Copy Markdown
Member

/lgtm
/approve

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2022
@tekton-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 3bdc67c into tektoncd:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants