Pinning sigstore/scaffolding/actions/setup version#512
Conversation
|
Hi @bcaton85. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
/lgtm |
| - name: Install mirror, kind, knative + sigstore | ||
| uses: sigstore/scaffolding/actions/setup@main | ||
| with: | ||
| version: v0.3.0 |
There was a problem hiding this comment.
Also please add this:
k8s-version 1.22
so like this:
with:
version: "v0.3.0"
k8s-version: "v1.22.x"
There was a problem hiding this comment.
Because 23 is being goofy:
sigstore/scaffolding#81
|
/ok-to-test |
|
/lgtm |
|
@vaikas seems |
|
@bcaton85 So, it seems like the tests were passing fine just a few days ago here: https://github.com/tektoncd/chains/runs/7697397547?check_suite_focus=true What's curious is that it was running very old version So I wonder if you could just use an older version of the action, instead of using I guess your uses would look like this: And take out the with. At least I think that should run the version that was working just fine before. |
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
|
I'm tempted to just drop 1.21 - it's EOL anyway. 🤔 |
|
Sounds good, updated to use the hash. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wlynch The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.