Skip to content

Fix for issue #515, This PR ensures only those signers which are specified as signers for any artifact are initialized.#519

Merged
tekton-robot merged 1 commit into
tektoncd:mainfrom
jagathprakash:dev
Aug 12, 2022
Merged

Fix for issue #515, This PR ensures only those signers which are specified as signers for any artifact are initialized.#519
tekton-robot merged 1 commit into
tektoncd:mainfrom
jagathprakash:dev

Conversation

@jagathprakash

@jagathprakash jagathprakash commented Aug 12, 2022

Copy link
Copy Markdown
Member

Changes

Fixes #515
This PR ensures only those signers which are specified as signers for any artifact are initialized.
This change ensures that we do not initialize unwanted signers for which we might not have all necessary configs, which was resulting in unwanted errors in logs.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 12, 2022
@tekton-robot

Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/signing.go 78.9% 75.5% -3.4

@wlynch wlynch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Main piece of feedback is let's update the commit message / PR body to add more details on what the change does - https://github.com/tektoncd/community/blob/main/standards.md#commits

My rule of thumb is you should be able to have a rough idea of what the change is doing even if you only have access to git log / git blame.

Comment thread pkg/chains/signing_test.go Outdated
Comment thread pkg/chains/signing_test.go Outdated
@tekton-robot

Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/signing.go 78.9% 75.5% -3.4

@tekton-robot

Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/signing.go 78.9% 75.5% -3.4

…ich we might not have all necessary configs, which was resulting in unwanted errors in logs.
@jagathprakash

Copy link
Copy Markdown
Member Author

LGTM!

Main piece of feedback is let's update the commit message / PR body to add more details on what the change does - https://github.com/tektoncd/community/blob/main/standards.md#commits

My rule of thumb is you should be able to have a rough idea of what the change is doing even if you only have access to git log / git blame.

@wlynch thanks for the review! Agree to the requirement for detailed messaging. I have updated the PR message as well as the commit to be more detailed.

@jagathprakash jagathprakash requested a review from wlynch August 12, 2022 18:41
@jagathprakash jagathprakash changed the title Fix for issue #515 Fix for issue #515, This PR ensures only those signers which are specified as signers for any artifact are initialized. Aug 12, 2022
@tekton-robot

Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/chains/signing.go 78.9% 75.5% -3.4

@wlynch wlynch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2022
@tekton-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2022
@tekton-robot tekton-robot merged commit d0b024d into tektoncd:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Noisy error message in controller log

3 participants