Fix for issue #515, This PR ensures only those signers which are specified as signers for any artifact are initialized.#519
Conversation
|
The following is the coverage report on the affected files.
|
wlynch
left a comment
There was a problem hiding this comment.
LGTM!
Main piece of feedback is let's update the commit message / PR body to add more details on what the change does - https://github.com/tektoncd/community/blob/main/standards.md#commits
My rule of thumb is you should be able to have a rough idea of what the change is doing even if you only have access to git log / git blame.
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
…ich we might not have all necessary configs, which was resulting in unwanted errors in logs.
@wlynch thanks for the review! Agree to the requirement for detailed messaging. I have updated the PR message as well as the commit to be more detailed. |
|
The following is the coverage report on the affected files.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wlynch The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Fixes #515
This PR ensures only those signers which are specified as signers for any artifact are initialized.
This change ensures that we do not initialize unwanted signers for which we might not have all necessary configs, which was resulting in unwanted errors in logs.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes