Skip to content

Add spiffe-csi driver support to authentication part#604

Merged
tekton-robot merged 1 commit into
tektoncd:mainfrom
developer-guy:main
Nov 28, 2022
Merged

Add spiffe-csi driver support to authentication part#604
tekton-robot merged 1 commit into
tektoncd:mainfrom
developer-guy:main

Conversation

@developer-guy

@developer-guy developer-guy commented Nov 1, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com

/cc @pxp928 @mlieberman85 @sudo-bmitch @wlynch @Dentrax

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Add spiffe-csi driver support to authenticaiotn part

@tekton-robot tekton-robot requested a review from wlynch November 1, 2022 12:10
@tekton-robot

tekton-robot commented Nov 1, 2022

Copy link
Copy Markdown

@developer-guy: GitHub didn't allow me to request PR reviews from the following users: pxp928, mlieberman85, sudo-bmitch, dentrax.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com

/cc @pxp928 @mlieberman85 @sudo-bmitch @wlynch @Dentrax

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Add spiffe-csi driver support to authenticaiotn part

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot

tekton-robot commented Nov 1, 2022

Copy link
Copy Markdown

Hi @developer-guy. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 1, 2022
@developer-guy developer-guy changed the title Add spiffe-csi driver support to authenticaiotn part Add spiffe-csi driver support to authentication part Nov 1, 2022
@developer-guy developer-guy force-pushed the main branch 2 times, most recently from b1f67d0 to e3de95d Compare November 1, 2022 13:01
@wlynch

wlynch commented Nov 1, 2022

Copy link
Copy Markdown
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 1, 2022
wlynch
wlynch approved these changes Nov 1, 2022
View reviewed changes

@wlynch wlynch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 1, 2022
pxp928
pxp928 approved these changes Nov 1, 2022
View reviewed changes

@pxp928 pxp928 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Dentrax
Dentrax reviewed Nov 1, 2022
View reviewed changes
Comment thread docs/authentication.md Outdated
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2022
@developer-guy developer-guy requested review from pxp928 and wlynch and removed request for pxp928 and wlynch November 2, 2022 07:13
@lcarva lcarva mentioned this pull request Nov 2, 2022
Closed
@wlynch

wlynch commented Nov 4, 2022

Copy link
Copy Markdown
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2022
@lcarva

lcarva commented Nov 23, 2022

Copy link
Copy Markdown
Contributor

@developer-guy, a rebase should fix the CI test.

@developer-guy

developer-guy commented Nov 23, 2022

Copy link
Copy Markdown
Contributor Author

I'm going to do that ASAP 🫡

@developer-guy
Add spiffe-csi driver support to authentication part
23ecda4 
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2022
@developer-guy

developer-guy commented Nov 24, 2022

Copy link
Copy Markdown
Contributor Author

It seems that everything is fine now.
/cc @wlynch @lcarva

lcarva
lcarva approved these changes Nov 28, 2022
View reviewed changes

@lcarva lcarva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2022
@tekton-robot

tekton-robot commented Nov 28, 2022

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva, pxp928, wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit f006d76 into tektoncd:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcarva lcarva lcarva approved these changes
@wlynch wlynch Awaiting requested review from wlynch
+2 more reviewers
@Dentrax Dentrax Dentrax left review comments
@pxp928 pxp928 pxp928 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@wlynch wlynch

@lcarva lcarva

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@developer-guy @tekton-robot @wlynch @lcarva @Dentrax @pxp928