Skip to content

Bump scaffolding release, use newer pipelines.#614

Merged
tekton-robot merged 2 commits into
tektoncd:mainfrom
vaikas:new-scaffold
Nov 17, 2022
Merged

Bump scaffolding release, use newer pipelines.#614
tekton-robot merged 2 commits into
tektoncd:mainfrom
vaikas:new-scaffold

Conversation

@vaikas

@vaikas vaikas commented Nov 16, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Ville Aikas vaikas@chainguard.dev

Changes

This is only changes for integration tests against Sigstore.

  • Use sigstore scaffolding 0.4.13
  • Use Tekton CLI 0.26.1
  • Use Pipelines v0.41.0
  • Drop tests with k8s 1.22, add tests with k8s 1.25

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 16, 2022
@wlynch

wlynch commented Nov 16, 2022

Copy link
Copy Markdown
Member

Thanks @vaikas! Can you rebase on https://github.com/tektoncd/chains/pull/613/files so we can pull both of these in?

(I suspect this change fixes the issues we were seeing in the other PR).

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas

vaikas commented Nov 16, 2022

Copy link
Copy Markdown
Contributor Author

@wlynch sure thing. I poked around in pipelines since I recalled there was some work getting pipeline to work with 1.25 but couldn't figure out it the support was added, so left it out first :)

@vaikas

vaikas commented Nov 16, 2022

Copy link
Copy Markdown
Contributor Author

Well that was... unexpected...:

ERROR: (gcloud.beta.container.clusters.create) ResponseError: code=409, message=Already exists: projects/tekton-prow-11/locations/us-central1/clusters/tchains-e2e-cls1592982433668534272.
2022/11/16 20:49:26 process.go:155: Step 'gcloud beta container clusters create --quiet --enable-autoscaling --min-nodes=1 --max-nodes=3 --scopes=cloud-platform --no-issue-client-certificate --project=tekton-prow-11 --region=us-central1 --machine-type=n1-standard-4 --image-type=cos_containerd --num-nodes=1 --network=tchains-e2e-net1592982433668534272 --cluster-version=1.23.8-gke.1900 tchains-e2e-cls1592982433668534272' finished in 1m3.814157374s
2022/11/16 20:49:26 main.go:319: Something went wrong: starting e2e cluster: error creating cluster: error during gcloud beta container clusters create --quiet --enable-autoscaling --min-nodes=1 --max-nodes=3 --scopes=cloud-platform --no-issue-client-certificate --project=tekton-prow-11 --region=us-central1 --machine-type=n1-standard-4 --image-type=cos_containerd --num-nodes=1 --network=tchains-e2e-net1592982433668534272 --cluster-version=1.23.8-gke.1900 tchains-e2e-cls1592982433668534272: exit status 1

@vaikas

vaikas commented Nov 16, 2022

Copy link
Copy Markdown
Contributor Author

/retest

@wlynch wlynch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2022
@tekton-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2022
@tekton-robot tekton-robot merged commit 24dadca into tektoncd:main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants