Skip to content

Added GHA to run go vet and go fmt checks.#644

Merged
tekton-robot merged 1 commit into
tektoncd:mainfrom
bendory:main
Dec 13, 2022
Merged

Added GHA to run go vet and go fmt checks.#644
tekton-robot merged 1 commit into
tektoncd:mainfrom
bendory:main

Conversation

@bendory

@bendory bendory commented Dec 13, 2022

Copy link
Copy Markdown
Contributor

Changes

Added GHA to run go vet and go fmt checks.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [N/A] Has Docs included if any changes are user facing
  • [N/A] Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • [N/A] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [N/A] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 13, 2022
@bendory

bendory commented Dec 13, 2022

Copy link
Copy Markdown
Contributor Author

Happily, go vet and go fmt are clean in this repo. That was not the case over in pipelines, so I'm adding this GHA here too to prevent us from losing integrity down the road.

Comment thread .github/workflows/goclean.yml

@lcarva lcarva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2022
@tekton-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2022
@tekton-robot tekton-robot merged commit 6d3449f into tektoncd:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants