Add labels and annotations to attestation#692
Merged
Conversation
tekton-robot
added
needs-rebase
lcarva
force-pushed
the
labels-annotations
branch
from
d33b669 to
6186e23
Compare
tekton-robot
removed
the
needs-rebase
|
The following is the coverage report on the affected files.
|
lcarva
force-pushed
the
labels-annotations
branch
2 times, most recently
from
2e37b9b to
bdf5af3
Compare
tekton-robot
added
size/L
chitrangpatel
approved these changes
Jan 26, 2023
chitrangpatel
left a comment
chitrangpatel
left a comment
Contributor
There was a problem hiding this comment.
Just one nit to double check.
wlynch
reviewed
Jan 27, 2023
wlynch
left a comment
wlynch
left a comment
Member
There was a problem hiding this comment.
Mostly LGTM! Just some minor comments.
lcarva
force-pushed
the
labels-annotations
branch
3 times, most recently
from
af49193 to
71151a2
Compare
Labels and annotations are added to the PipelineRun and TaskRun attestations in `.predicate.invocation.environment`. Additionally, for PipelineRun attestations, each task also contains its own `.invocation.environment` with the corresponding labels and annotations. Fixes tektoncd#591 Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
lcarva
force-pushed
the
labels-annotations
branch
from
71151a2 to
72827c1
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chitrangpatel, wlynch The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Contributor
Author
|
/test pull-tekton-chains-integration-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #591
Changes
Labels and annotations are added to the PipelineRun and TaskRun attestations in
.predicate.invocation.environment. Additionally, for PipelineRun attestations, each task also contains its own.invocation.environmentwith the corresponding labels and annotations.Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes