Skip to content

Cleanup: generics replace deprecated sets.String.#776

Merged
tekton-robot merged 1 commit into
tektoncd:mainfrom
bendory:sets
Apr 18, 2023
Merged

Cleanup: generics replace deprecated sets.String.#776
tekton-robot merged 1 commit into
tektoncd:mainfrom
bendory:sets

Conversation

@bendory

@bendory bendory commented Apr 18, 2023

Copy link
Copy Markdown
Contributor

Changes

There are no expected functional changes in this PR.

In the k8s.io/apimachinery/pkg/util/sets package, the specified Set types like sets.String have been deprecated in favor of generics like sets.Set[string]. This PR changes to the generic type across our repository.

See: https://pkg.go.dev/k8s.io/apimachinery/pkg/util/sets

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

/kind cleanup

Release Notes

ACTION REQUIRED: users who build against Tekton Chains may need to adjust their code to use
generic `sets.Set[string]` types in place of `sets.String` types. See https://pkg.go.dev/k8s.io/apimachinery/pkg/util/sets for details.

There are no expected functional changes in this PR.

In the k8s.io/apimachinery/pkg/util/sets package, the specified Set
types like `sets.String` have been deprecated in favor of generics like
`sets.Set[string]`. This PR makes the change across our repository.

See: https://pkg.go.dev/k8s.io/apimachinery/pkg/util/sets
@tekton-robot tekton-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 18, 2023
@tekton-robot tekton-robot requested review from chuangw6 and wlynch April 18, 2023 19:28

@lcarva lcarva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Just a minor comment for consideration.

Comment thread pkg/chains/signing.go
@tekton-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2023
@lcarva

lcarva commented Apr 18, 2023

Copy link
Copy Markdown
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2023
@tekton-robot tekton-robot merged commit cc4e317 into tektoncd:main Apr 18, 2023
@bendory bendory deleted the sets branch April 18, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants