Skip to content

add ConfigMap and Service for observability#836

Merged
tekton-robot merged 1 commit intotektoncd:mainfrom
avinal:avinal/add-metrics
Jun 26, 2023
Merged

add ConfigMap and Service for observability#836
tekton-robot merged 1 commit intotektoncd:mainfrom
avinal:avinal/add-metrics

Conversation

@avinal
Copy link
Copy Markdown
Member

@avinal avinal commented Jun 22, 2023

Changes

  • this PR adds ConfigMap for configuring metrics and a Service to expose the port

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

- Metrics can be accessed by exposing the Service `tekton-chains-controller`
- adds a ConfigMap for configuring metrics

@tekton-robot tekton-robot requested review from chuangw6 and wlynch June 22, 2023 06:39
@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 22, 2023
@tekton-robot
Copy link
Copy Markdown

Hi @avinal. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Comment thread config/conifg-observability.yaml
Comment thread config/conifg-observability.yaml
Comment thread config/observability-service.yaml Outdated
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2023
Signed-off-by: Avinal Kumar <avinal@redhat.com>
@avinal avinal force-pushed the avinal/add-metrics branch from 4909068 to a2b6dfe Compare June 22, 2023 14:23
Copy link
Copy Markdown
Contributor

@lcarva lcarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2023
@tekton-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wlynch
Copy link
Copy Markdown
Member

wlynch commented Jun 26, 2023

/ok-to-test
/lgtm

@tekton-robot tekton-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 26, 2023
@tekton-robot tekton-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 26, 2023
@tekton-robot tekton-robot merged commit ef7a579 into tektoncd:main Jun 26, 2023
@avinal avinal deleted the avinal/add-metrics branch June 27, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants