Skip to content

Bump golang.org/x/net from 0.14.0 to 0.17.0 (v0.13.x)#955

Merged
tekton-robot merged 2 commits into
tektoncd:release-v0.13.xfrom
lcarva:update-golang.org/x/net
Oct 18, 2023
Merged

Bump golang.org/x/net from 0.14.0 to 0.17.0 (v0.13.x)#955
tekton-robot merged 2 commits into
tektoncd:release-v0.13.xfrom
lcarva:update-golang.org/x/net

Conversation

@lcarva

@lcarva lcarva commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

Release Notes

NONE

@lcarva
Bump golang.org/x/net from 0.14.0 to 0.17.0
3153b26 
Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 17, 2023
@lcarva

lcarva commented Oct 17, 2023

Copy link
Copy Markdown
Contributor Author

/test pull-tekton-chains-integration-tests

hmm I wonder if these tests are no longer working properly on this old branch.

@lcarva

lcarva commented Oct 17, 2023

Copy link
Copy Markdown
Contributor Author

Seeing lots of FailedScheduling Pod status: no nodes available to schedule pods

wlynch
wlynch approved these changes Oct 17, 2023
View reviewed changes

@wlynch wlynch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2023
@tekton-robot

tekton-robot commented Oct 17, 2023

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@khrm

khrm commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

/test pull-tekton-chains-integration-tests

khrm
khrm reviewed Oct 18, 2023
View reviewed changes

@khrm khrm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update pipelines version here. Pipelines is too old and can't be deployed in k8s version used in cluster for testing.

@khrm

khrm commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

https://github.com/lcarva/chains/blob/3153b26296b24b87e176b7e22f5766875c52c72b/test/e2e-tests.sh#L31

Change the version here.

@lcarva
Update e2e tests to use v0.41 of pipelines
0a3aa15 
Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@wlynch

wlynch commented Oct 18, 2023

Copy link
Copy Markdown
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@tekton-robot tekton-robot merged commit 76dd499 into tektoncd:release-v0.13.x Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wlynch wlynch wlynch approved these changes
@chuangw6 chuangw6 Awaiting requested review from chuangw6
@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa
+1 more reviewer
@khrm khrm khrm left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@wlynch wlynch

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lcarva @tekton-robot @khrm @wlynch