feat: add PipelineRun support to storage/gcs#971
Conversation
tekton-robot
added
the
size/L
aaron-prindle
force-pushed
the
fix-852-v3
branch
from
cc1b4bf to
f94913d
Compare
|
The following is the coverage report on the affected files.
|
aaron-prindle
force-pushed
the
fix-852-v3
branch
from
f94913d to
f7b339a
Compare
|
The following is the coverage report on the affected files.
|
aaron-prindle
force-pushed
the
fix-852-v3
branch
3 times, most recently
from
6a6f1f5 to
466c073
Compare
|
The following is the coverage report on the affected files.
|
aaron-prindle
force-pushed
the
fix-852-v3
branch
from
466c073 to
dc947f2
Compare
|
The following is the coverage report on the affected files.
|
aaron-prindle
force-pushed
the
fix-852-v3
branch
from
dc947f2 to
b7e05f7
Compare
|
The following is the coverage report on the affected files.
|
lcarva
left a comment
lcarva
left a comment
There was a problem hiding this comment.
Just some minor comments, but overall this looks good!
Prior to this commit the storage/gcs client didn't support PipelineRuns, only TaskRuns which is not in parity with our other storage interfaces. This PR adds PipelineRuns support to storage/gcs.
aaron-prindle
force-pushed
the
fix-852-v3
branch
from
b7e05f7 to
69babbe
Compare
|
Thanks for the review @lcarva! I believe I have addressed all of the feeback mentioned, lmk if there is anything additional to do here. |
|
The following is the coverage report on the affected files.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcarva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
3 participants
fixes #852
Prior to this commit the storage/gcs client didn't support PipelineRuns, only TaskRuns which is not in parity with our other storage interfaces. This PR adds PipelineRuns support to storage/gcs.
//nolint:staticcheckused similar to elsewhere in code as otherwise golangci-lint reports usage of deprecated v1beta1 APIs, snippet below:NOTE: This is my first tektoncd/chains PR. If I misunderstood anything about the issue, changes necessary, best practices, etc. I'm happy to iterate as needed. Thanks!