Cleanup/remove deprecate chains cmd#2769
Conversation
|
@adityavshinde the CI isn't green here |
|
cc @vdemeester |
|
/kind cleanup |
|
@pratap0007 @divyansh42 - could you help reviewing this PR. Thankyou |
divyansh42
left a comment
There was a problem hiding this comment.
Thanks @adityavshinde for the PR!
Changes look good! Can you please squash the commits into two? We can keep one commit for the chains cmd removal and another one for the OCI buckets-related changes.
Run make generated chore: run update-codegen.sh to fix CI
4c4f4a6 to
fd853b7
Compare
Thank you @divyansh42 for reviewing. I have squashed the commits into 2 commits. |
|
Reviewing once before I put lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyansh42, waveywaves The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
fixes: #2751
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes