Skip to content

chore: migrate cherry-pick workflow to use plumbing reusable workflow#3085

Merged
tekton-robot merged 1 commit intotektoncd:mainfrom
vdemeester:issue-3004-cherry-pick
Dec 10, 2025
Merged

chore: migrate cherry-pick workflow to use plumbing reusable workflow#3085
tekton-robot merged 1 commit intotektoncd:mainfrom
vdemeester:issue-3004-cherry-pick

Conversation

@vdemeester
Copy link
Member

Changes

This PR migrates the operator repository to use the centralized cherry-pick workflow from tektoncd/plumbing (addresses tektoncd/plumbing#3004).

What changed:

  • Replaced local 250+ line cherry-pick implementation with a simple workflow_call to the reusable workflow in plumbing
  • Uses the same pinned SHA (4b57443b85569e5bb7d9ee440bf5cae99cb642cb) as tektoncd/pipeline for consistency
  • Reduces file from 256 lines to 33 lines

Benefits:

  • Single source of truth for cherry-pick logic across all tektoncd repos
  • Easier to maintain (updates happen in plumbing, propagate everywhere)
  • Consistent behavior across repositories
  • Reduced code duplication

Testing:
No functional changes - the workflow behavior remains identical, it just delegates to the centralized implementation.

Submitter Checklist

  • Run make test lint before submitting a PR (N/A - workflow file only)
  • Includes tests (N/A - workflow file only)
  • Includes docs (comprehensive inline documentation retained)
  • Commit messages follow commit message best practices

Release Notes

NONE

- Replace local 250+ line implementation with simple workflow_call
- Use centralized cherry-pick logic from tektoncd/plumbing
- Pin to same SHA as tektoncd/pipeline for consistency
- Reduce maintenance burden and ensure consistent behavior

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Dec 10, 2025
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 10, 2025
@anithapriyanatarajan
Copy link
Contributor

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Dec 10, 2025
@anithapriyanatarajan
Copy link
Contributor

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2025
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anithapriyanatarajan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [anithapriyanatarajan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2025
@vdemeester
Copy link
Member Author

/kind misc

@tekton-robot tekton-robot merged commit 278066d into tektoncd:main Dec 10, 2025
13 checks passed
@vdemeester vdemeester deleted the issue-3004-cherry-pick branch December 10, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants