proxy-aae: override WORKERS_SECRET_NAMESPACE for OpenShift#3244
Conversation
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/L
khrm
left a comment
khrm
left a comment
There was a problem hiding this comment.
/assign @pramodbindal @jkhelil
|
/kind bug |
| common.DeploymentEnvVars([]corev1.EnvVar{ | ||
| { | ||
| Name: "WORKERS_SECRET_NAMESPACE", | ||
| Value: "openshift-kueue-operator", |
There was a problem hiding this comment.
instead of hardcoding the namespace. can we extract this from some kueue resource ?
There was a problem hiding this comment.
Isn't the worker secret needed in Kueue's namespace? That's why we need to configure it.
There was a problem hiding this comment.
If it's installed somewhere, we can use options.
There was a problem hiding this comment.
There is always an option to install the kueue operator in non-default namespace.
SO if customer installs there. then this will fail
There was a problem hiding this comment.
Customer can set options field on deployment to change this environment variable.
There was a problem hiding this comment.
editing operator owned deployment is not something they should be doing. Maybe we can set this value in tektonconfig if namespace is different from default
So in scheduler config. can we have a field called kueue-namespace which defaults to "openshift-kueue-operator" in openshift and kueue-system in kubernetes
There was a problem hiding this comment.
No, they aren't editing deployment. They are using the options field. Check the document.
There was a problem hiding this comment.
khrm
force-pushed
the
proxy-aae-openshift-namespace-transform
branch
2 times, most recently
from
7b1828a to
2f55233
Compare
On OpenShift, the kueue operator runs in the openshift-kueue-operator namespace rather than the upstream default kueue-system. Add an OpenShift transform in the proxy-aae extension to replace the WORKERS_SECRET_NAMESPACE env var accordingly. Export DeploymentEnvVars in the common package to make the transformer reusable. Add tests covering both the default transform and the ability for spec.options to override the value. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
khrm
force-pushed
the
proxy-aae-openshift-namespace-transform
branch
from
2f55233 to
b7561bc
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkhelil The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
4 participants
On OpenShift, the kueue operator runs in the openshift-kueue-operator namespace rather than the upstream default kueue-system. Add an OpenShift transform in the proxy-aae extension to replace the WORKERS_SECRET_NAMESPACE env var accordingly. Export DeploymentEnvVars in the common package to make the transformer reusable. Add tests covering both the default transform and the ability for spec.options to override the value.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes