fix: prevent Chain and Result installation on lite profile

[alliasgher]

Changes

Fix the lite profile installing TektonChain and TektonResult components when it should only install TektonPipelines.

Root Cause

The TektonTrigger section correctly gates creation on both the disabled flag AND the profile:

if !tc.Spec.Trigger.Disabled && (tc.Spec.Profile == v1alpha1.ProfileAll || tc.Spec.Profile == v1alpha1.ProfileBasic) {

But the TektonChain and TektonResult sections only checked the disabled flag:

if !tc.Spec.Chain.Disabled {   // missing profile check
if !tc.Spec.Result.Disabled {  // missing profile check

Since Chain.Disabled and Result.Disabled default to false, the lite profile would create these components, then the FinalizeKind path would try to delete them, causing a reconciliation loop.

Fix

Add the same ProfileAll || ProfileBasic check to both Chain and Result conditions, matching the existing Trigger pattern.

Verification

• go build ./... passes
• Lite profile will now only create TektonPipelines (as documented)
• Basic profile continues to create Pipelines + Triggers + Chains + Results
• All profile creates everything including Dashboard

Fixes #2781

NONE

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign savitaashture after the PR has been reviewed.
You can assign the PR to them by writing /assign @savitaashture in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[khrm]

/lgtm

[alliasgher]

/assign @savitaashture

[anithapriyanatarajan]

/ok-to-test

[alliasgher]

The e2e test TestTektonConfigTestSuite/Test02_ChangeProfile is failing in CI (run) on this PR. The test sequence is default → lite → basic → all, and it's timing out on the lite → basic transition with:

config   devel   False   Components not in ready state: TektonResult reconcile again and proceed

Some analysis on why my fix exposes this:

• Before this PR, the lite profile silently installed Chain + Result in addition to Pipelines (the bug). So the existing Result CR was always present, and lite → basic was effectively a no-op for Result.
• With this PR, lite correctly deletes Result. The lite → basic transition has to re-create it, and that re-creation appears to be hitting a race condition or stuck state (see the controller status above).

This is a real underlying issue in the Result reconciliation/transition flow, but my fix is what surfaced it. Two ways forward:

1. Land this fix as-is and treat the transition issue as a separate bug to fix in the Result reconciler.
2. Leave the buggy behavior in place until the transition issue is fixed.

I'd appreciate guidance from @khrm / @savitaashture on the preferred path. Happy to investigate the Result reconciler stuck-transition issue as a follow-up if option (1) is preferred.

[anithapriyanatarajan]

@alliasgher Thank you for this PR. Would recommend to have the CI passing before the PR is merged. Hence, would it be possible to proceed with your proposed first option in last comment:

Land this fix as-is and treat the transition issue as a separate bug to fix in the Result reconciler..

If you have the bandwidth, please raise a new issue and submit a PR for that. Once merged, we can rerun the tests on this PR. If bandwidth is tight, even a GitHub issue to capture the problem would be helpful.

Very keen to get this PR merged, but want to do it the right way. Feel free to flag any concerns. Thanks again!

[anithapriyanatarajan]

/hold

[alliasgher]

Filed #3377 to capture the TektonResult lite → basic transition issue. I'll start looking at the reconciler this week and open a separate PR when I have a fix; happy for this PR to wait on that per your suggestion. @anithapriyanatarajan