fix: replace symlinks with mv/cp in prepare-draft-release#3366
Merged
tekton-robot merged 1 commit intotektoncd:mainfrom Apr 22, 2026
Merged
fix: replace symlinks with mv/cp in prepare-draft-release#3366tekton-robot merged 1 commit intotektoncd:mainfrom
tekton-robot merged 1 commit intotektoncd:mainfrom
Conversation
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/S
runc fails with 'mkdir /workspace/shared/repo: file exists' when a step's workingDir points through a symlink. The prepare-draft-release task was creating symlinks (repo → git, release → bucket/<version>) to bridge the naming gap between the operator pipeline and the create-draft-release-oci task. Instead, use the source-subpath and release-subpath params added in plumbing (65d3485eedbb) to pass the correct paths directly. This removes the need for any symlinks, mv, or cp operations. Also update the plumbing git resolver pin to 7abffd25eb2e.
vdemeester
force-pushed
the
fix-draft-release-symlinks
branch
from
94dca5e to
cfecbc9
Compare
Contributor
|
/kind cleanup |
tekton-robot
added
the
kind/cleanup
Contributor
|
/lgtm |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anithapriyanatarajan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
runc fails with
mkdir /workspace/shared/repo: file existswhen a step'sworkingDirpoints through a symlink. Theprepare-draft-releasetask creates symlinks (repo → git,release → bucket/<version>) for thecreate-draft-release-ocitask, but runc's container init tries tomkdirtheworkingDirpath and fails when it encounters the symlink.Replace
ln -sfnwithmv(for git checkout) andcp -r(for release artifacts) to givecreate-draft-releasereal directories instead of symlinks.Observed in two consecutive release runs:
release-patch-lm7md—PodCreationFailedrelease-patch-bh52z—PodCreationFailedA follow-up PR will update the plumbing task to accept configurable paths, removing the need for any renaming.
Submitter Checklist
make test lintbefore submitting a PRRelease Notes