chore: fix failing unit tests during upgrade#3441
Open
Conversation
tekton-robot
added
the
release-note-none
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
the
size/XS
Contributor
Author
Contributor
Author
|
/kind cleanup |
tekton-robot
added
the
kind/cleanup
Signed-off-by: Anitha Natarajan <anataraj@redhat.com>
anithapriyanatarajan
force-pushed
the
fix-unit-test
branch
from
fde84da to
dc997b0
Compare
tekton-robot
added
size/S
Contributor
Author
|
@tektoncd/operator-maintainers - could we please merge so that we can merge -#3432 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR addresses the unit test failures during PAC upgrade. #3432
TestUpdateAdditionControllerConfigMap was failing because the expected ConfigMap fixture was stale. PaC PR tektoncd/pipelines-as-code#2605 (merged April 17, 2026) added three new fields to the Settings struct for distributed tracing support:
The operator's ConvertPacStructToConfigMap uses reflection over all Settings struct fields, so these new keys are automatically included in the generated ConfigMap as empty-string defaults. The test fixture had not been updated to reflect this.
Fix
Added the three new tracing keys (all defaulting to "") to the expected ConfigMap fixture:
test-expected-additional-pac-cm.yaml
No production code changes were required this is purely a test fixture sync to match the upstream PaC vendor update.
Tests Impacted
TestUpdateAdditionControllerConfigMap
TestUpdateAdditionControllerConfigMapWithDefaultCM
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes