fix: do not fail PipelineRun when TaskRef reconciles with retryable err #9099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
|
/kind fix |
tekton-robot
added
the
size/L
|
@aThorp96: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/kind bug |
aThorp96
force-pushed
the
retryable-validation-error
branch
from
03e4771 to
b77b00a
Compare
With this change, no `ErrCouldntValidateObjectRetryable` returned by DryRunValidate results in a PipelineRun being marked as failed. Previously, the only errors which were actually retried were naming conflicts, server-timeouts, timeouts, and too-many-requests. Unknown errors were marked as "Retryable", however they still caused the PipelineRun to fail since `resolutioncommon.IsErrTransient` did not check if the err was of type `ErrCouldntValidateObjectRetryable`
vdemeester
approved these changes
Oct 27, 2025
aThorp96
force-pushed
the
retryable-validation-error
branch
from
b77b00a to
c5d3a6d
Compare
tekton-robot
added
the
approved
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester, waveywaves The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With this change, no
ErrCouldntValidateObjectRetryablereturned by DryRunValidate results in a PipelineRun being marked as failed. Previously, the only errors which were actually retried were naming conflicts, server-timeouts, timeouts, and too-many-requests. Unknown errors were still marked as Retryable, but they still caused the pipelinerun to fail.Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes