Skip to content

chore: centralize ko base image configuration #9110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2025
Merged

chore: centralize ko base image configuration #9110

merged 1 commit into from
Oct 29, 2025
+13 −35

Conversation

@waveywaves
Copy link
Member

Changes

  • Add defaultBaseImage to .ko.yaml for consistent base image usage
  • Remove inline .ko.yaml generation from CI workflow
  • Remove inline .ko.yaml generation from presubmit test script
  • Use repository's .ko.yaml as single source of truth

This eliminates duplication and makes base image configuration easier to maintain and update in one place.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Oct 28, 2025
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 28, 2025
@waveywaves waveywaves force-pushed the optimize-ko-yaml-usage branch from 4e25688 to 04e4bbd Compare October 28, 2025 15:57
@waveywaves waveywaves added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Oct 28, 2025
@waveywaves waveywaves force-pushed the optimize-ko-yaml-usage branch from 04e4bbd to f6216c5 Compare October 28, 2025 16:10
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 28, 2025
vdemeester
vdemeester reviewed Oct 28, 2025
View reviewed changes
@waveywaves waveywaves force-pushed the optimize-ko-yaml-usage branch from f6216c5 to 82ef38b Compare October 28, 2025 16:19
@waveywaves
chore: centralize ko base image configuration
e18ca51 
- Add defaultBaseImage to .ko.yaml for consistent base image usage
- Remove inline .ko.yaml generation from CI workflow
- Remove inline .ko.yaml generation from presubmit test script
- Use repository's .ko.yaml as single source of truth

This eliminates duplication and makes base image configuration
easier to maintain and update in one place.

Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
@waveywaves waveywaves force-pushed the optimize-ko-yaml-usage branch from 82ef38b to e18ca51 Compare October 28, 2025 16:30
vdemeester
vdemeester reviewed Oct 28, 2025
View reviewed changes
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2025
@waveywaves
Copy link
Member Author

/retest

1 similar comment
@waveywaves
Copy link
Member Author

/retest

vdemeester
vdemeester approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2025
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vdemeester
Copy link
Member

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2025
vdemeester
vdemeester reviewed Oct 29, 2025
View reviewed changes
@vdemeester
Copy link
Member

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2025
@tekton-robot tekton-robot merged commit 7c060ac into tektoncd:main Oct 29, 2025
78 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdemeester vdemeester vdemeester approved these changes

@abayer abayer Awaiting requested review from abayer

@twoGiants twoGiants Awaiting requested review from twoGiants

Assignees

@vdemeester vdemeester

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Tekton Community Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@waveywaves @tekton-robot @vdemeester