fix: clarify error message in TooManyValueExeption#21
Merged
Conversation
…re values are present
ledex
requested review from
a team,
julian-spierefka and
mherwig
and removed request for
a team
|
mherwig
approved these changes
Apr 9, 2024
Th3Shadowbroker
approved these changes
Apr 9, 2024
julian-spierefka
approved these changes
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When only a single value is needed for the logical operator, but more/fewer values are present,
TooManyValueExceptionused to be thrown. However, the error was misleading and only covered the case where more values were present.This MR fixes this and improves the naming of the exception.When only a single value is needed for the logical operator, but more/fewer values are present,
TooManyValueExceptionused to be thrown. However, the error was misleading and only covered the case where more values were present.This PR fixes that and improves the naming of the exception.