fix(data-grid/text-cell): pass accessibilityTitle to prefix and suffix icons#2487
Open
Ricardo-Tele wants to merge 2 commits intotelekom:mainfrom
Open
fix(data-grid/text-cell): pass accessibilityTitle to prefix and suffix icons#2487Ricardo-Tele wants to merge 2 commits intotelekom:mainfrom
Ricardo-Tele wants to merge 2 commits intotelekom:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #2194 by ensuring accessibilityTitle values are forwarded to prefix/suffix icons rendered in Data Grid text cells, improving screen-reader support for icon-only affordances in cells.
Changes:
- Extend the Data Grid text cell renderer to pass
accessibility-titleto prefix/suffix icon components (withlabelas fallback). - Add unit tests verifying explicit and fallback accessibility titles for text-cell prefix/suffix icons.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
packages/components/src/components/data-grid/cell-handlers/text-cell.tsx |
Forwards accessibility-title to dynamically-rendered prefix/suffix icon tags, falling back to the field label. |
packages/components/src/components/data-grid/data-grid.spec.ts |
Adds regression tests for forwarding and fallback behavior for text cell icon accessibility titles. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+49
to
+53
| expect(icons).toHaveLength(2); | ||
| expect(icons[0].getAttribute('accessibility-title')).toBe('Status'); | ||
| expect(icons[0].querySelector('title').textContent).toBe('Status'); | ||
| expect(icons[1].getAttribute('accessibility-title')).toBe('Status'); | ||
| expect(icons[1].querySelector('title').textContent).toBe('Status'); |
Comment on lines
+6
to
+12
| beforeEach(() => { | ||
| (global as any).ResizeObserver = class { | ||
| observe() {} | ||
| unobserve() {} | ||
| disconnect() {} | ||
| }; | ||
| }); |
Comment on lines
+25
to
+30
| expect(icons[0].getAttribute('accessibility-title')).toBe( | ||
| 'Download attachment' | ||
| ); | ||
| expect(icons[0].querySelector('title').textContent).toBe( | ||
| 'Download attachment' | ||
| ); |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #2194 by ensuring accessibilityTitle information is forwarded to prefix/suffix icons rendered inside data grid text cells, improving screen-reader support.
Changes:
- Forward
iconPrefixAccessibilityTitle/iconSuffixAccessibilityTitleto the renderedscale-icon-*elements inTextCell, with a fallback to the columnlabel. - Add Stencil spec tests validating the forwarded icon accessibility titles and the label fallback behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/components/src/components/data-grid/cell-handlers/text-cell.tsx | Passes accessibility-title to prefix/suffix icons, defaulting to the field label. |
| packages/components/src/components/data-grid/data-grid.spec.ts | Adds regression tests covering the new forwarding behavior and fallback behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+87
to
+89
| {h(`scale-icon-${iconPrefix}`, { | ||
| 'accessibility-title': iconPrefixAccessibilityTitle ?? label, | ||
| })} |
Comment on lines
+95
to
+97
| {h(`scale-icon-${iconSuffix}`, { | ||
| 'accessibility-title': iconSuffixAccessibilityTitle ?? label, | ||
| })} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2194
The accessibilityTitle is now forwarded to prefix and suffix icons rendered in data grid text cells. This improves accessibility for screen reader users. Regression tests were added to cover the updated behavior.