Skip to content

fix: add zlib to Windows build#307

Merged
patrick-stephens merged 7 commits into
mainfrom
302_fix_windows_build
May 22, 2026
Merged

fix: add zlib to Windows build#307
patrick-stephens merged 7 commits into
mainfrom
302_fix_windows_build

Conversation

@patrick-stephens
Copy link
Copy Markdown
Contributor

@patrick-stephens patrick-stephens commented May 21, 2026

Resolves #302 by ensuring we provide zlib during the build for Windows.


Summary by cubic

Fixes Windows builds by installing zlib via vcpkg, linking ZLIB::ZLIB, and passing the vcpkg toolchain/triplet to CMake; also installs libgit2 via vcpkg. Reverts zstd detection to the 4.1.x pkg-config flow; resolves #302.

  • Refactors
    • Windows workflow cleanup: split configure/build steps, print build logs for debugging, and remove build package upload.

Written for commit 3eaaf89. Summary will update on new commits. Review in cubic

Signed-off-by: Patrick Stephens <pat@telemetryforge.io>
@patrick-stephens
Copy link
Copy Markdown
Contributor Author

/build windows

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions
Copy link
Copy Markdown

Build results for /build on PR #307:

@patrick-stephens
Copy link
Copy Markdown
Contributor Author

Unfortunately the PR build comment runner invokes the workflow from the default branch rather than the updated one.

@patrick-stephens patrick-stephens added the build-windows Option to enable building of Windows packages only for a PR to test label May 21, 2026
Signed-off-by: Patrick Stephens <pat@telemetryforge.io>
Signed-off-by: Patrick Stephens <pat@telemetryforge.io>
@coveralls
Copy link
Copy Markdown

coveralls commented May 22, 2026

Coverage Report for CI Build 26290622149

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage decreased (-0.001%) to 58.243%

Details

  • Coverage decreased (-0.001%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 5 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

5 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
src/flb_http_client.c 3 43.88%
src/flb_storage.c 2 73.58%

Coverage Stats

Coverage Status
Relevant Lines: 160303
Covered Lines: 94454
Line Coverage: 58.92%
Relevant Branches: 35307
Covered Branches: 19476
Branch Coverage: 55.16%
Branches in Coverage %: Yes
Coverage Strength: 5822.52 hits per line

💛 - Coveralls

Signed-off-by: Patrick Stephens <pat@telemetryforge.io>
Signed-off-by: Patrick Stephens <pat@telemetryforge.io>
Signed-off-by: Patrick Stephens <pat@telemetryforge.io>
Signed-off-by: Patrick Stephens <pat@telemetryforge.io>
@patrick-stephens patrick-stephens removed the build-windows Option to enable building of Windows packages only for a PR to test label May 22, 2026
@patrick-stephens patrick-stephens marked this pull request as ready for review May 22, 2026 13:28
@patrick-stephens patrick-stephens requested a review from a team as a code owner May 22, 2026 13:28
@patrick-stephens patrick-stephens merged commit d6deb18 into main May 22, 2026
14 checks passed
@patrick-stephens patrick-stephens deleted the 302_fix_windows_build branch May 22, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4.2.4 build failures

2 participants