fix: add zlib to Windows build#307
Merged
Merged
Conversation
Signed-off-by: Patrick Stephens <pat@telemetryforge.io>
Contributor
Author
|
/build windows |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
Author
|
Unfortunately the PR build comment runner invokes the workflow from the default branch rather than the updated one. |
Signed-off-by: Patrick Stephens <pat@telemetryforge.io>
Signed-off-by: Patrick Stephens <pat@telemetryforge.io>
Coverage Report for CI Build 26290622149Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage decreased (-0.001%) to 58.243%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions5 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
Signed-off-by: Patrick Stephens <pat@telemetryforge.io>
Signed-off-by: Patrick Stephens <pat@telemetryforge.io>
Signed-off-by: Patrick Stephens <pat@telemetryforge.io>
Signed-off-by: Patrick Stephens <pat@telemetryforge.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #302 by ensuring we provide zlib during the build for Windows.
Summary by cubic
Fixes Windows builds by installing
zlibviavcpkg, linkingZLIB::ZLIB, and passing thevcpkgtoolchain/triplet to CMake; also installslibgit2viavcpkg. Revertszstddetection to the 4.1.x pkg-config flow; resolves #302.Written for commit 3eaaf89. Summary will update on new commits. Review in cubic