ci: switch to using SHAs for actions#105
Merged
patrick-stephens merged 1 commit intomainfrom Mar 19, 2026
Merged
Conversation
Signed-off-by: Patrick Stephens <pat@telemetryforge.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR improves CI supply-chain security by pinning GitHub Actions dependencies to immutable commit SHAs and adds automation to enforce that policy going forward.
Changes:
- Replace
uses: ...@v*action references with commit-SHA pins across workflows. - Add a Pinact workflow job to review/enforce action pinning on PRs.
- Update Dependabot configuration to group GitHub Actions updates.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.pinact.yaml |
Adds Pinact configuration file to support automated action pinning checks. |
.github/workflows/lint.yaml |
Pins actions to SHAs and adds a new job to review/enforce pinned actions on PRs. |
.github/workflows/cron-run-scan.yaml |
Pins external actions (GCP auth/secrets, checkout, docker login, create PR) to SHAs. |
.github/workflows/call-add-mapping-version.yaml |
Pins external actions (GCP auth/secrets, checkout, create PR) to SHAs in the reusable workflow. |
.github/workflows/build-offline.yaml |
Pins checkout and upload-artifact actions to SHAs. |
.github/dependabot.yml |
Groups GitHub Actions updates and simplifies YAML values. |
Comments suppressed due to low confidence (1)
.github/workflows/lint.yaml:37
- The Actionlint job downloads and executes a script from
raw.githubusercontent.com/.../main/...at runtime. This undermines the goal of pinning CI dependencies, since the contents can change without review. Consider pinning the script URL to a specific commit SHA (or using a versioned release artifact/checksum) so the workflow is reproducible and supply-chain risk is reduced.
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- run: |
echo "::add-matcher::.github/actionlint-matcher.json"
bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash)
./actionlint -color -shellcheck=
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+49
to
+56
| actions-pin-sha: | ||
| runs-on: ubuntu-latest | ||
| name: PR - Actions Pin SHA | ||
| permissions: | ||
| contents: read | ||
| # For ReviewDog to post comments to the PR | ||
| pull-requests: write | ||
| steps: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change to using SHAs for all actions to improve security posture.