Rusev/async context #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the inital commit of async static mocking with passing the required test method information.
…llContext for .NET Framework and AsyncLocal for .NET Core
# Conflicts: # Telerik.JustMock/Core/Context/MSpecContextResolver.cs # Telerik.JustMock/Core/Context/MockingContextResolverBase.cs
ivo-stoilov
previously approved these changes
Apr 18, 2019
Contributor
There was a problem hiding this comment.
@lyubomir-rusev IMO Implementation of IAsyncContextResolver will look much better if it organized in just one class having condition compilation inside.
mihail-vladov
previously requested changes
Apr 19, 2019
Collaborator
mihail-vladov
left a comment
mihail-vladov
left a comment
There was a problem hiding this comment.
- The new functionality is made public which in my opinion is not required.
- There is no copyright message for the new files.
Contributor
Author
|
Check latest commits. |
ivo-stoilov
reviewed
Apr 19, 2019
ivo-stoilov
previously approved these changes
Apr 19, 2019
ivo-stoilov
requested changes
May 2, 2019
ivo-stoilov
approved these changes
May 3, 2019
ivo-stoilov
dismissed
mihail-vladov’s stale review
All requested changes has been addressed
ivo-stoilov
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.