Skip to content

Conversation

@svdimitr
Copy link
Contributor

Points of possible further discussion:

I have made the examples in separate sections because:

  • They were too long to be on a single page
  • Maybe it is not a bad idea to showcase how an app should be structured to the users as we have more and more tickets regarding the general behavior of the framework

Shall we leave them like that?

@svdimitr svdimitr marked this pull request as ready for review November 16, 2020 14:12
@svdimitr svdimitr self-assigned this Nov 16, 2020
Copy link
Contributor

@marin-bratanov marin-bratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a sentence at the beginning of the "between trees" example to indicate whose OnDrop fires when - does it fire for the source or destination tree.

Perhaps also try adding the code as subsequent code snippets and not as tabbed code to see if it is more readable. If you already tried and it isn't - I am completely fine with it that way.

Also, is there a need for the button that toggles Draggale for the Flat treeview example? If not, we can probably remove it.

EDIT: Maybe add some explanations around the Position enum - maybe add a sentence when introducing it that the user will see a hint where they are dropping (above,below,over) if there is one. If there isn't - ignore this.

@svdimitr
Copy link
Contributor Author

Consider adding a sentence at the beginning of the "between trees" example to indicate whose OnDrop fires when - does it fire for the source or destination tree.

Perhaps also try adding the code as subsequent code snippets and not as tabbed code to see if it is more readable. If you already tried and it isn't - I am completely fine with it that way.

Also, is there a need for the button that toggles Draggale for the Flat treeview example? If not, we can probably remove it.

EDIT: Maybe add some explanations around the Position enum - maybe add a sentence when introducing it that the user will see a hint where they are dropping (above,below,over) if there is one. If there isn't - ignore this.

Thank you for the comments, I will take the following actions:

  1. I will remove the button for the Draggable.
  2. I tried adding the code as subsequent code snippets and it became something like 300 + lines, which I found hard to read.
  3. I will add more explanations as suggested and re-request review

@marin-bratanov
Copy link
Contributor

I do not need to see it for two sentences, go ahead and merge

@svdimitr svdimitr merged commit 146c328 into master Nov 17, 2020
@svdimitr svdimitr deleted the docs-treeview-drag-drop branch November 17, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants