-
Notifications
You must be signed in to change notification settings - Fork 80
Popup docs #1877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Popup docs #1877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikoevska
reviewed
Jan 23, 2024
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
dimodi
reviewed
Jan 25, 2024
dimodi
reviewed
Jan 25, 2024
dimodi
reviewed
Jan 25, 2024
dimodi
reviewed
Jan 25, 2024
dimodi
requested changes
Jan 25, 2024
Contributor
dimodi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add the Popup to
_config.yml, so that it appears on the home page. Use the "Interactivity and UX" section for consistency with the demos. - The correct anchor alignment explanation is the opposite.
- Minor suggestions
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
…d enhance the refresh description
Contributor
Author
|
I have made the requested changes :) |
ikoevska
reviewed
Jan 29, 2024
ikoevska
reviewed
Jan 29, 2024
ikoevska
reviewed
Jan 29, 2024
ikoevska
reviewed
Jan 29, 2024
ikoevska
reviewed
Jan 29, 2024
dimodi
approved these changes
Jan 29, 2024
Co-authored-by: Iva Stefanova Koevska-Atanasova <koevska@progress.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <koevska@progress.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.