Skip to content

Conversation

@svdimitr
Copy link
Contributor

No description provided.

@svdimitr svdimitr requested a review from a team January 23, 2024 13:17
@svdimitr svdimitr self-assigned this Jan 23, 2024
@svdimitr svdimitr requested a review from a team as a code owner January 23, 2024 13:17
svdimitr and others added 20 commits January 24, 2024 16:48
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
svdimitr and others added 5 commits January 25, 2024 11:11
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <admatha@gmail.com>
Copy link
Contributor

@dimodi dimodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add the Popup to _config.yml, so that it appears on the home page. Use the "Interactivity and UX" section for consistency with the demos.
  • The correct anchor alignment explanation is the opposite.
  • Minor suggestions

svdimitr and others added 10 commits January 26, 2024 15:29
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
Co-authored-by: Dimo Dimov <961014+dimodi@users.noreply.github.com>
@svdimitr
Copy link
Contributor Author

I have made the requested changes :)

@svdimitr svdimitr requested a review from dimodi January 26, 2024 13:49
dimodi and others added 4 commits January 29, 2024 18:02
Co-authored-by: Iva Stefanova Koevska-Atanasova <koevska@progress.com>
Co-authored-by: Iva Stefanova Koevska-Atanasova <koevska@progress.com>
@dimodi dimodi merged commit 046d779 into master Jan 29, 2024
@github-actions github-actions bot deleted the popup-docs branch January 29, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants