Skip to content

kb(Notification): Add KB for single Notification instance #2450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2024
Merged

kb(Notification): Add KB for single Notification instance #2450

merged 2 commits into from
Oct 21, 2024

Conversation

@dimodi
Copy link
Contributor

@dimodi dimodi commented Oct 18, 2024 •
edited
Loading

@dimodi dimodi added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Oct 18, 2024
@dimodi dimodi requested a review from a team October 18, 2024 14:38
@dimodi dimodi requested a review from a team as a code owner October 18, 2024 14:38
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024

Hello @dimodi,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production

@dimodi dimodi mentioned this pull request Oct 18, 2024
Merged
ikoevska
ikoevska approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@ikoevska ikoevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, you can include the actual use case for reusing a single notification somewhere in the description (that is - the why and the benefits).

@dimodi dimodi merged commit 60d1c6f into master Oct 21, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Oct 21, 2024
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024

Here you are the link to your PR to production: 2454

@github-actions github-actions bot deleted the kb-one-notification branch October 21, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikoevska ikoevska ikoevska approved these changes

Assignees

No one assigned

Labels

merge-to-production Use this label to get a comment to choose whether to merge the PR to production

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dimodi @ikoevska